Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 5069: Add pagination to product drives #5077

Merged
merged 2 commits into from
Mar 7, 2025
Merged

Issue 5069: Add pagination to product drives #5077

merged 2 commits into from
Mar 7, 2025

Conversation

henry-r18
Copy link
Contributor

Resolves #5069

Description

  • Added pagination to Product Drives controller and corresponding view
    • Utilizes Kaminari pagination Gem already in use in project

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Test case checks that:

  • product drives table will only display the number of rows set in Kaminari.config.default_per_page
  • pagination controls appear if the per-page limit is exceeded

To test, run bundle exec rspec spec/requests/product_drives_requests_spec.rb from project directory

cielf
cielf reviewed Mar 7, 2025
View reviewed changes
Copy link
Collaborator

@cielf cielf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes functional testing -- over to @dorner for technical comments.

@cielf cielf requested a review from dorner March 7, 2025 18:38
dorner
dorner approved these changes Mar 7, 2025
View reviewed changes
Copy link
Collaborator

@dorner dorner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on this end!

@dorner dorner merged commit 4821d88 into rubyforgood:main Mar 7, 2025
11 checks passed
@henry-r18 henry-r18 deleted the 5069-add-pagination-to-product-drives branch March 8, 2025 00:42
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 9, 2025

@henry-r18: Your PR Issue 5069: Add pagination to product drives is part of today's Human Essentials production release: 2025.03.09.
Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cielf cielf cielf left review comments

@dorner dorner dorner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add pagination to product drives
3 participants
@henry-r18 @dorner @cielf